Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
cc @RyanTheOptimist @DavidSchinazi now with 103s :-) |
RyanTheOptimist
previously approved these changes
Nov 16, 2021
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Woo hoo! Looks awesome. One small question.
| testEnvoyProxying1xx(false, false, true); | ||
| } | ||
|
|
||
| TEST_P(ProtocolIntegrationTest, EnvoyProxying102) { |
Contributor
There was a problem hiding this comment.
Should we also have a 103 test here?
DavidSchinazi
previously approved these changes
Nov 16, 2021
| * bandwidth_limit: added :ref:`bandwidth limit stats <config_http_filters_bandwidth_limit>` *request_enforced* and *response_enforced*. | ||
| * config: the log message for "gRPC config stream closed" now uses the most recent error message, and reports seconds instead of milliseconds for how long the most recent status has been received. | ||
| * dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>` This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false. | ||
| * http: envoy will now proxy 102 and 103 headers from upstream, though as with 100s only the first 1xx response headers will be sent. This behavioral change by can temporarily revertd by setting runtime guard ``envoy.reloadable_features.proxy_102_103`` to false. |
Contributor
There was a problem hiding this comment.
Suggested change
| * http: envoy will now proxy 102 and 103 headers from upstream, though as with 100s only the first 1xx response headers will be sent. This behavioral change by can temporarily revertd by setting runtime guard ``envoy.reloadable_features.proxy_102_103`` to false. | |
| * http: envoy will now proxy 102 and 103 headers from upstream, though as with 100s only the first 1xx response headers will be sent. This behavioral change by can temporarily reverted by setting runtime guard ``envoy.reloadable_features.proxy_102_103`` to false. |
alyssawilk
dismissed stale reviews from DavidSchinazi and RyanTheOptimist
via
c9370ad
This was referenced Jun 12, 2024
RyanTheOptimist
pushed a commit
that referenced
this pull request
Jul 8, 2024
Proxying 104s from upstream. `104 Upload Resumption Supported` is introduced in [`draft-ietf-httpbis-resumable-upload`](https://datatracker.ietf.org/doc/draft-ietf-httpbis-resumable-upload/) spec. Continuation of the discussion in #19044 Modeled after: #19023 Risk Level: Low (minor refactor) Testing: new integration test Docs Changes: N/A Release Notes: > http: envoy will now proxy 104 headers from upstream, though as with 100s only the first 1xx response headers will be sent. This behavior can be temporarily reverted by setting runtime guard `envoy.reloadable_features.proxy_104` to false. 104 headers are designated by [ietf's draft-ietf-httpbis-resumable-upload rfc](https://datatracker.ietf.org/doc/draft-ietf-httpbis-resumable-upload/). Runtime guard: > `envoy.reloadable_features.proxy_104` --------- Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxying 102s from upstream
Risk Level: Low (minor refactor)
Testing: new integration test
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.proxy_102
Fixes #18844